Make file picker autocompletion case-insensitive #464
Merged
+85
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
commented
Jun 11, 2025
| @@ -5,6 +5,7 @@ use std::cmp::Ordering; | |||
| use std::fs; | |||
| use std::path::{Path, PathBuf}; | |||
|
|
|||
| use edit::arena::scratch_arena; | |||
There was a problem hiding this comment.
Suppress whitespace: https://github.com/microsoft/edit/pull/464/files?w=1
lhecker
commented
Jun 11, 2025
| let mut files = Vec::new(); | ||
| let mut off = 0; | ||
| // ["..", directories, files] | ||
| let mut dirs_files = [Vec::new(), Vec::new(), Vec::new()]; |
There was a problem hiding this comment.
This split allows us to use binary search to quickly find matching items during autocompletion. Previously it was O(n). We can't use a single list with a single binary search, because the list is sorted by directories first and then files.
DHowett
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.