Add keybindings to go to previous and next file. #546
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lhecker
requested changes
Jul 2, 2025
| pub fn activate_next(&mut self) { | ||
| if self.list.len() > 1 { | ||
| if let Some(doc) = self.list.pop_front() { | ||
| self.list.push_back(doc); |
There was a problem hiding this comment.
Items in the list are sorted from most to least recently activated. This would mark the current document as the least recent one, but it's actually the 2nd most recent one. But the next call to activate_next would then need to swap the 2nd and 3rd items, and so on.
I believe this shows that we need a "tab order". Given that we currently have neither tabs nor the ability to reorder them, I'm not sure whether this can be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTRL-Page Up/CTRL-Page Down keybindings for navigating to next/previous open files.
Fixes #530