feat: enforce and normalize package dependencies #316
Conversation
Hotell
force-pushed
the
resolve-dependency-issues
branch
from
898c6eb to
d3516d2
Compare
Hotell
changed the title
| "@fluentui/react-jsx-runtime": ">=9.0.29 < 10.0.0", | ||
| "@fluentui/keyboard-keys": "~9.0.6", | ||
| "@fluentui/react-tabster": "~9.14.0", |
There was a problem hiding this comment.
using version range that is not present in the monorepo - changed to ^ , please provide context if you need to use ~ for version range ( in this case current decision introduces duplicates in user land 🚨 )
| @@ -1,4 +1,4 @@ | |||
| import type { BrandVariants } from '@fluentui/react-theme'; | |||
There was a problem hiding this comment.
using imports from suite is highly recommended if possible
| unstable_hasDefault: true, | ||
| }); | ||
| export const useChatMoverAttribute_unstable = (): ReturnType< | ||
| typeof useArrowNavigationGroup |
There was a problem hiding this comment.
using transitive dependency package for internal type assertion is a bad practice - recommended solution is to always use direct dependency - ideally from suite package.
this mitigates direct dependency requirement for tabster
packages/react-data-grid-react-window/src/components/DataGridBody/useDataGridBody.tsx
Show resolved
Hide resolved
| @@ -3,30 +3,18 @@ | |||
| "$schema": "../../node_modules/nx/schemas/project-schema.json", | |||
| "sourceRoot": "packages/react-gamepad-navigation/src", | |||
| "projectType": "library", | |||
| "release": { | |||
There was a problem hiding this comment.
seems this project used old generator - removing cruft
| @@ -1,6 +1,6 @@ | |||
| import type { SlotClassNames, TabState } from '@fluentui/react-components'; | |||
| import { mergeClasses } from '@fluentui/react-components'; | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
we don't use this rule anymore
| "dependencies": { | ||
| "@fluentui/react-jsx-runtime": "^9.0.29", | ||
| "@fluentui/react-tabs": "^9.5.0", |
There was a problem hiding this comment.
this is intended change (until nrwl/nx#29853 lands)
- NOTE that this will not introduce duplicates as the version range for sub-package is compatible with suite
Hotell
requested review from
a team,
dmytrokirpa,
mainframev,
spmonahan and
marcosmoura
as code owners
Hotell
force-pushed
the
resolve-dependency-issues
branch
from
1b88375 to
ebf519e
Compare
… Component generation
Hotell
force-pushed
the
resolve-dependency-issues
branch
from
43c9de1 to
c617ea0
Compare
@nx/dependency-checkfor all projectseslint-plugin-importfrom monorepocomponentgenerator makinglibrarygenerator platform/technology agnosticRelated issues: