-
Notifications
You must be signed in to change notification settings - Fork 45
Adding token analyzer logic and tests #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandonthomas
wants to merge
76
commits into
microsoft:main
Choose a base branch
from
brandonthomas:token-analyzer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
294ef7e
to
869c626
Compare
fixing lint issues updating readme
add end to end test with button styles example
save button analysis for comparison
Process output of shorthands functions and map tokens from output add more complex shorthand case update tests
exclude storybook files (there shouldn't be any anyways)
update readme add deps and update yarn lock
mltejera
reviewed
May 29, 2025
…file system roots update default path to just run at the directory it's called from
mltejera
reviewed
May 30, 2025
"yargs": "^17.7.2" | ||
}, | ||
"scripts": { | ||
"analyze-tokens": "(cd ../.. && nx build token-analyzer) && node ../../dist/packages/token-analyzer/lib-commonjs/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build error in windows due to 'cd ../..' being held onto for second command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change I'm adding all of the logic and tests for the token-analyzer package. This package includes the ability to build a mapping of token usage in style files to their component state, which properties are impacted, etc. This tool is a static analysis tool and it specifically targets Griffel based styles so it won't work with other libraries for now. I've included a pretty detailed description in the README so check that for more information.
Other notes: