-
Notifications
You must be signed in to change notification settings - Fork 2.8k
update slider to use semantic tokens #34758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update slider to use semantic tokens #34758
Conversation
Pull request demo site: URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Semantic theme has one weird feature where the bar itself shrinks vs default state on hover/press if they are variant sizes - can see this happening in Kumo theme.
Let's see if we can fix this up so that when indicator size changes the progress bar remains constant, we'll likely need to account for the indicator width during hover/pressed states in width style (or set styles to display the thumb in absolute space to avoid it affecting width at all)
e9afe39
to
75e43a8
Compare
So figured out that the rail width would change depending on thumb size because of this The thumb size changing on hover/press is due to the semantic tokens all being different - you have to set |
75e43a8
to
1e947cc
Compare
428641d
into
microsoft:extended-tokens
Updates react-slider to use semantic tokens.
Gaps noted here