Skip to content

More efficient mcp.json + fixed typos and trailing spaces #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

DavidIsrawi
Copy link
Member

Purpose

The mcp.json template found in the course calls for the Windows Command Prompt to run a node script within it. There are two challenges with this approach:

  • cmd is specific to Windows
  • the mcp.json format already supports node, hence the cmd portion is redundant as we can run the node script directly

As I was doing this change, I noticed some typos in the repo, so I went ahead and addressed the ones I noticed 🙂

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs or modules?

which includes deployment, settings and usage instructions.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 06:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines the mcp.json template by removing the Windows-specific cmd wrapper in favor of direct node execution and cleans up typos and trailing spaces across documentation.

  • Switch mcp.json server entries from cmd /c node … to node build/index.js
  • Correct spelling and grammar errors in multiple README files
  • Remove stray trailing whitespace and fix formatting inconsistencies

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
03-GettingStarted/04-vscode/solution/README.md Updated server command from "cmd" to "node" and simplified args list
03-GettingStarted/04-vscode/README.md Revised example commands, fixed typos (“GitHun” → “GitHub”), and cleaned up numbering
03-GettingStarted/02-client/README.md Fixed typo “protcol” → “protocol” in the import libraries section

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@leestott leestott merged commit aa1e24a into microsoft:main Jun 17, 2025
1 check passed
@DavidIsrawi DavidIsrawi deleted the fixMcpJson branch June 17, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants