[QNN EP] Add remove_initializer_from_input in qnn.preprocess #25102
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add argument "--exclude_initializer_from_input" to remove initializer from input if model.ir_version >= 4 - Add function argument on remove_initializer_from_input - Modify the onnxruntime_python.cmake to include remove_initializer_from_input.py
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new option to exclude initializers from model inputs for ONNX models with ir_version >=4, addressing an issue related to initializers appearing as graph inputs.
- Adds a new argument "--exclude_initializer_from_input" across relevant scripts and the CMake build file.
- Refactors the remove_initializer_from_input function to accept a model argument and return a boolean indicating whether modifications were made.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/python/remove_initializer_from_input.py | Refactored function to remove initializers from input and now returns a boolean flag; updated main block accordingly. |
| onnxruntime/python/tools/quantization/execution_providers/qnn/preprocess.py | Integrated the exclude_initializer_from_input option into the QNN preprocessing logic. |
| onnxruntime/python/tools/qnn/preprocess.py | Added new argument and documentation updates for excluding initializers from inputs. |
| cmake/onnxruntime_python.cmake | Updated to include the new remove_initializer_from_input.py script in the build process. |
| args = get_args() | ||
|
|
||
| model = onnx.load(args.input) | ||
| def remove_initializer_from_input(model: onnx.ModelProto) -> bool: | ||
| if model.ir_version < 4: | ||
| print("Model with ir_version below 4 requires to include initilizer in graph input") |
There was a problem hiding this comment.
There is a spelling error in the printed message: 'initilizer' should be corrected to 'initializer'.
Suggested change
| print("Model with ir_version below 4 requires to include initilizer in graph input") | |
| print("Model with ir_version below 4 requires to include initializer in graph input") |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Initializer <name> appears in graph inputs and will not be treated as constant value/weight., we require the remove_initializer_from_input to be included inqnn.preprocess