-
Notifications
You must be signed in to change notification settings - Fork 309
Test system-installed libcurl
availability on non-Windows
#1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vicroms
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
vicroms:test-libcurl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcurl
availability on non-Windowslibcurl
availability on non-Windows
This seems kinda conservative to me; does any system exist where curl (the command line tool) isn't powered by libcurl? We also require git for most everything which must also link with libcurl... |
BillyONeal
reviewed
Apr 15, 2025
BillyONeal
reviewed
Apr 15, 2025
BillyONeal
reviewed
Apr 15, 2025
Thomas1664
reviewed
Apr 16, 2025
Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine if
libcurl
is available in the system by attempting to load it. At the moment we don't do anything with it, but we're tracking availability oflibcurl
as a replacement to the current download/upload implementation.