Add extension details button to Manage Trusted Extensions dialog #251510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
TylerLeonhardt
June 15, 2025 01:31
| this._commandService.executeCommand('_manageAccountPreferencesForExtension', e.item.extension.id, providerId) | ||
| )); | ||
| disposableStore.add(quickPick.onDidTriggerItemButton(e => { | ||
| const buttonIndex = e.button && e.item.buttons ? e.item.buttons.indexOf(e.button) : -1; |
There was a problem hiding this comment.
Instead of doing this check, save the button references as properties on the class and use those in the comparison
There was a problem hiding this comment.
Done! I've refactored the code to use class properties _viewDetailsButton and _managePreferencesButton and now use direct object comparison instead of indexOf. This is more efficient and cleaner. 98e4943
…omparison Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
TylerLeonhardt
June 15, 2025 02:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new button to each extension item in the "Manage Trusted Extensions" dialog that allows users to quickly view extension details.
Problem
When managing trusted extensions for authentication accounts, users had no easy way to view extension details to help them make informed decisions about which extensions should have access to their accounts.
Solution
Added an eye icon button next to each extension in the dialog that executes
workbench.extensions.searchwith an@id:extensionIdquery to open the Extensions view filtered to show the specific extension's details.Changes
Codicon.eye) button with tooltip "View extension details"workbench.extensions.search @id:extensionIdas requestedUser Experience
Users now see two buttons per extension:
Clicking the eye button opens the Extensions view with the specific extension displayed, helping users make informed decisions about extension permissions.
Fixes #204876.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.orgnode-gyp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.