Skip to content

Add App Installer v1.26 #268284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

florelis
Copy link
Member

@florelis florelis commented Jun 24, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268284-20250624-1

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 24, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 24, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268284-20250624-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jun 24, 2025
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268284-20250624-3

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jun 24, 2025
@florelis
Copy link
Member Author

Thank you for the corrections @mdanish-kh !
I'm so not used to updating manifests 😅

@mdanish-kh
Copy link
Contributor

I think you probably tried doing this one manaully since wingetcreate would've failed for this one (because 1.10 had an additional arm installer, and this one doesn't and wingetcreate requires the number of installers to be the same). Moving forward a simple command like this should work

wingetcreate update Microsoft.AppInstaller --version 1.26.400.0 --urls "https://github.com/microsoft/winget-cli/releases/download/v1.11.400/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle" --submit

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Changes-Requested Changes Requested label Jun 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 24, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 24, 2025
@wingetbot
Copy link
Collaborator

=== manifests\m\Microsoft\AppInstaller\1.26.400.0 ===
Missing Properties value based on version 1.25.390.0:

  • Installers

@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 24, 2025 21:31
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9e47ebc into microsoft:master Jun 24, 2025
1 check passed
@florelis florelis deleted the appinstaller branch June 24, 2025 21:32
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants