Skip to content

[Instrumentation.ConfluentKafka] rethrow exception on consume and process #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

vhatsura
Copy link
Contributor

@vhatsura vhatsura commented Jun 16, 2025

Fixes #2843

Changes

Rethrow exception on ConsumeAndProcessMessageAsync extension message

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vhatsura vhatsura requested a review from a team as a code owner June 16, 2025 11:05
Copy link

linux-foundation-easycla bot commented Jun 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vhatsura / name: Vadim Hatsura (f139d29, 5283d1d)
  • ✅ login: Kielek / name: Piotr Kiełkowicz (a8226f9)

@github-actions github-actions bot added the comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka label Jun 16, 2025
@Kielek
Copy link
Contributor

Kielek commented Jun 23, 2025

@g7ed6e, could you please check?

@g7ed6e
Copy link
Contributor

g7ed6e commented Jun 23, 2025

Thanks @vhatsura

@Kielek
Copy link
Contributor

Kielek commented Jun 23, 2025

@vhatsura, could you please add entry to the appriopriate CHANGELOG.md

@Kielek Kielek changed the title fix(kafka instrumentation): rethrow exception on consume and process [Instrumentation.ConfluentKafka] rethrow exception on consume and process Jun 23, 2025
@vhatsura
Copy link
Contributor Author

@vhatsura, could you please add entry to the appriopriate CHANGELOG.md

@Kielek, done

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.10%. Comparing base (71655ce) to head (a8226f9).
Report is 896 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...luentKafka/OpenTelemetryConsumeResultExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2847       +/-   ##
===========================================
- Coverage   73.91%   14.10%   -59.82%     
===========================================
  Files         267       17      -250     
  Lines        9615      631     -8984     
===========================================
- Hits         7107       89     -7018     
+ Misses       2508      542     -1966     
Flag Coverage Δ
unittests-Instrumentation.ConfluentKafka 14.10% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...luentKafka/OpenTelemetryConsumeResultExtensions.cs 0.00% <0.00%> (ø)

... and 277 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek merged commit 7508248 into open-telemetry:main Jun 25, 2025
62 checks passed
thompson-tomo pushed a commit to thompson-tomo/opentelemetry-dotnet-contrib that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ConsumeAndProcessMessageAsync swallow exceptions
3 participants