-
Notifications
You must be signed in to change notification settings - Fork 668
Renovate: skip commit upgrades of otel-go #7405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7405 +/- ##
=======================================
+ Coverage 81.4% 82.2% +0.7%
=======================================
Files 205 205
Lines 18075 17949 -126
=======================================
+ Hits 14728 14768 +40
+ Misses 2925 2743 -182
- Partials 422 438 +16 🚀 New features to boost your workflow:
|
CHANGELOG.md
Outdated
@@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|||
### Changed | |||
|
|||
- `Renovate`: skip commit upgrades of `otel-go`. (#7405) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't need a changelog entry.
renovate.json
Outdated
"labels": [ | ||
"Skip Changelog", | ||
"dependencies" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep your changes limited to what's actually being done in the PR rather than also adding different style?
"matchPackageNames": [ | ||
"go.opentelemetry.io/otel/**" | ||
], | ||
"allowedVersions": "/^v\\d+\\.\\d+\\.\\d+$/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have this been tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with a Go script to verify that it correctly identifies semantic versions vs pseudo-versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #6436
This PR addresses #6192
Skip commit-based upgrades for
go.opentelemetry.io/otel/**
, allow only semver releases.