Skip to content

Renovate: skip commit upgrades of otel-go #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sonalgaud12
Copy link
Contributor

This PR addresses #6192

Skip commit-based upgrades for go.opentelemetry.io/otel/**, allow only semver releases.

@sonalgaud12 sonalgaud12 requested a review from a team as a code owner May 30, 2025 11:03
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (83ccafe) to head (dfcf661).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7405     +/-   ##
=======================================
+ Coverage   81.4%   82.2%   +0.7%     
=======================================
  Files        205     205             
  Lines      18075   17949    -126     
=======================================
+ Hits       14728   14768     +40     
+ Misses      2925    2743    -182     
- Partials     422     438     +16     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CHANGELOG.md Outdated
@@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Changed

- `Renovate`: skip commit upgrades of `otel-go`. (#7405)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't need a changelog entry.

renovate.json Outdated
"labels": [
"Skip Changelog",
"dependencies"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep your changes limited to what's actually being done in the PR rather than also adding different style?

"matchPackageNames": [
"go.opentelemetry.io/otel/**"
],
"allowedVersions": "/^v\\d+\\.\\d+\\.\\d+$/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this been tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with a Go script to verify that it correctly identifies semantic versions vs pseudo-versions

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jun 4, 2025
@sonalgaud12 sonalgaud12 requested a review from dmathieu June 5, 2025 15:19
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants