-
Notifications
You must be signed in to change notification settings - Fork 672
[DO NOT MERGE] minsev: Fix to filter out only in SeverityTrace1..SeverityFatal4 severity range #7424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7424 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 205 205
Lines 17949 17952 +3
=====================================
+ Hits 14768 14774 +6
+ Misses 2743 2741 -2
+ Partials 438 437 -1
🚀 New features to boost your workflow:
|
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Marking as blocked by specification as I do not want us to go back and forth until: and maybe are resolved. |
From the SIG meetings discussions it seems that most prefer our current implementation: open-telemetry/opentelemetry-specification#4541 (comment). I will extract the Go docs improvements to a separate PR. |
Per open-telemetry/opentelemetry-specification#4541
From https://github.com/open-telemetry/opentelemetry-specification/blob/bdcf53d55285ae42339f37908a24ba6f3ac167cb/specification/logs/data-model.md?plain=1#L418-L423:
Currently the spec only describes how to compare values between 1 and 24.
All other values have undefined meaning.
The main reason is to NOT filter out records with
log.SeverityUndefined
severity which can be a common scenario.I also did my best to improve the docs.