otelconf: Increased test coverage for Prometheus-related code #7440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 205 205
Lines 17967 17967
=====================================
+ Hits 14794 14800 +6
+ Misses 2736 2731 -5
+ Partials 437 436 -1 🚀 New features to boost your workflow:
|
pellared
reviewed
Jun 9, 2025
dmathieu
added
the
Skip Changelog
pellared
reviewed
Jun 30, 2025
| assert.True(t, strings.Contains(addr, "localhost") || strings.Contains(addr, "127.0.0.1"), | ||
| "server address %s should contain localhost or 127.0.0.1", addr) | ||
|
|
||
| resp, err := http.DefaultClient.Get("http://" + server.Addr + "/metrics") |
There was a problem hiding this comment.
Suggested change
| resp, err := http.DefaultClient.Get("http://" + server.Addr + "/metrics") | |
| resp, err := http.DefaultClient.Get("http://" + addr + "/metrics") |
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| reader, err := prometheusReader(context.Background(), tt.config) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
This line is redundant with the next one
Suggested change
| assert.Error(t, err) |
Comment on lines
+1276
to
+1278
| if err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
Why is it not?
require.NoError(t, err)
require.NotNil(t, reader)| WithResourceConstantLabels: &IncludeExclude{}, | ||
| } | ||
| reader, err := prometheusReader(context.Background(), &cfg) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
Suggested change
| assert.Error(t, err) |
Comment on lines
+1477
to
+1479
| if err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
Why is it not?
require.NoError(t, err)
require.NotNil(t, reader)
pellared
reviewed
Jun 30, 2025
| } | ||
| } | ||
|
|
||
| func TestPrometheusReaderConfigurationOptions(t *testing.T) { |
There was a problem hiding this comment.
It this test missing for v0.3.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6821
Added test for prometheusReader function for both v0.3.0 & v0.2.0
Locally tested