Skip to content

docs(lambda): update handler docs #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

duncanista
Copy link
Contributor

What?

Updates docs to use the same handler for AWS Lambda instrumentation.

Notes

Requires open-telemetry/opentelemetry-lambda#1837 to be merged first.

also the ones in japanese
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duncanista, thanks very much for keeping the docs updated! We appreciate the initiative.

I've made a couple copy edit suggestions, and we should also get the @open-telemetry/lambda-extension-approvers to sign off.

Finally, while we appreciate the effort, please revert the changes to the localized version of this page. To keep track of drift, we have a more involved process for updating localized pages, and it's best to leave it to the localization teams.

Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@opentelemetrybot opentelemetrybot requested a review from a team June 6, 2025 01:13
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. I suggest we hold off on merging till after open-telemetry/opentelemetry-lambda#1837 is released though.

@tiffany76 tiffany76 added blocked and removed lang:ja labels Jun 6, 2025
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed, I'm just using this to block merging until we're ready.

@svrnm
Copy link
Member

svrnm commented Jun 23, 2025

looks like open-telemetry/opentelemetry-lambda#1837 is merged, so we can unblock?

@tylerbenson
Copy link
Member

Thanks for checking, but hasn't been released yet. We will circle back when we do.

@tylerbenson
Copy link
Member

Ok, this has been released now. Thanks.

@tiffany76 tiffany76 added this pull request to the merge queue Jul 5, 2025
Merged via the queue into open-telemetry:main with commit 9ee8df4 Jul 5, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Opened to Done in SIG Comms: Docs Translation Jul 5, 2025
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution @duncanista! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants