Skip to content

Clarify the maintainer bar based on the recent GC/TC discussion #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

reyang
Copy link
Member

@reyang reyang commented May 15, 2025

This is a follow up to the May. 14th, 2025 GC/TC meeting.

@open-telemetry/governance-committee @open-telemetry/technical-committee

@reyang reyang requested a review from a team as a code owner May 15, 2025 06:19
Comment on lines +85 to +89
SIG Security is open to all OpenTelemetry contributors and community members
interested in security. We welcome all levels of experience, from those who are
new to security to those who are seasoned experts. We encourage participation
from a diverse range of backgrounds and perspectives, as security is a
multifaceted field that benefits from a variety of viewpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be mostly a duplicate of what we already have for the community in general: https://github.com/open-telemetry/community/blob/main/mission-vision-values.md#community-values

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes sense to align the values because this project is part of OpenTelemetry.
I think it is reasonable to call it out here to encourage contributions, an alternative approach is to not have this statement and link to the community page, which could be less convenient for the users?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a link is fine. This seems unnecessary duplication. I don't see anything specific to SIG Security in this paragraph.

Copy link
Member Author

@reyang reyang May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a concrete suggestion how to rephrase this? We cannot put a bare link because it will break markdownlint.

Another way which I thought about - we just don't mention it here at all. I don't like this approach because it could give people a false impression that we try to make it harder for people to contribute.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrannajaryan I'll merge for now, please keep commenting here and I can follow up in a separate PR.

@reyang reyang enabled auto-merge (squash) May 19, 2025 15:51
@reyang reyang merged commit cf143a9 into open-telemetry:main May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants