-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: Allow prepared and non-prepared queries with set_var and resource_group hints to be cached. #62367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
planner: Allow prepared and non-prepared queries with set_var and resource_group hints to be cached. #62367
Conversation
Hi @wddevries. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62367 +/- ##
================================================
+ Coverage 72.9064% 73.3608% +0.4544%
================================================
Files 1751 1753 +2
Lines 484569 489374 +4805
================================================
+ Hits 353282 359009 +5727
+ Misses 109672 108631 -1041
- Partials 21615 21734 +119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/test check-dev2 |
@wddevries: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: terry1purcell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #60920
Problem Summary:
Prepared and non-prepared queries with set_var and resource_group hints cannot be cached.
What changed and how does it work?
This pull request makes two changes:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.