Skip to content

[core] fix get_max_resources_from_cluster_config #54455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xinyuangui2
Copy link
Contributor

@xinyuangui2 xinyuangui2 commented Jul 9, 2025

Why are these changes needed?

get_max_resources_from_cluster_config is only returning CPU, GPU, and TPU. But users might need to check other available resources, like memory.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
Copy link
Contributor

@alexeykudinkin alexeykudinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments, please address before landing

Signed-off-by: xgui <xgui@anyscale.com>
@alexeykudinkin alexeykudinkin enabled auto-merge (squash) July 9, 2025 20:48
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 9, 2025
@alexeykudinkin alexeykudinkin disabled auto-merge July 9, 2025 20:48
Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
@xinyuangui2 xinyuangui2 requested a review from raulchen July 9, 2025 21:42
@raulchen raulchen enabled auto-merge (squash) July 9, 2025 21:57
@raulchen raulchen merged commit ce539b3 into ray-project:master Jul 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants