[Core] Remove ineffectual TODO comment

[owenowenisme]

Why are these changes needed?

The TODO comment is outdated (I suppose), it says that we use a map to store TaskId <-> Work to avoid iterate through queue.

However, even if we have a map that does this, we still need to remove the element from tasks_to_schedule_ and infeasible_tasks_ queues, so we still need to iterate through them.

Therefore, we won't benefit from this.

ray/src/ray/raylet/scheduling/cluster_task_manager.cc

Lines 88 to 120 in 3cff3e5

	bool ClusterTaskManager::CancelTasks(
	std::function<bool(const std::shared_ptr<internal::Work> &)> predicate,
	rpc::RequestWorkerLeaseReply::SchedulingFailureType failure_type,
	const std::string &scheduling_failure_message) {
	bool tasks_cancelled = false;
	ray::erase_if<SchedulingClass, std::shared_ptr<internal::Work>>(
	tasks_to_schedule_, [&](const std::shared_ptr<internal::Work> &work) {
	if (predicate(work)) {
	RAY_LOG(DEBUG) << "Canceling task "
	<< work->task.GetTaskSpecification().TaskId()
	<< " from schedule queue.";
	ReplyCancelled(*work, failure_type, scheduling_failure_message);
	tasks_cancelled = true;
	return true;
	} else {
	return false;
	}
	});
	ray::erase_if<SchedulingClass, std::shared_ptr<internal::Work>>(
	infeasible_tasks_, [&](const std::shared_ptr<internal::Work> &work) {
	if (predicate(work)) {
	RAY_LOG(DEBUG) << "Canceling task "
	<< work->task.GetTaskSpecification().TaskId()
	<< " from infeasible queue.";
	ReplyCancelled(*work, failure_type, scheduling_failure_message);
	tasks_cancelled = true;
	return true;
	} else {
	return false;
	}
	});

Related issue number

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[gemini-code-assist]

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

[Copilot]

Pull Request Overview

Removes an outdated TODO that suggested indexing TaskID to Work for cancellation, which no longer provides benefit since queue iteration is still required.

• Deleted a two-line outdated comment in cluster_task_manager.h