Make bundling webcs fail if there are major errors #5629
Merged
+37
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No documentation updates required. |
zebreus
force-pushed
the
fix-webc-gitignore
branch
from
5c0bcd7 to
093cd11
Compare
syrusakbary
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour silently omits fs entries from a webc if there is a problem reading that directory and strictness is set to loose. However, an I/O error when reading a directory is a critical error and should be reported to the user. This PR changes the behaviour to abort and report that error to the user. That behaviour mirrors the behaviour when including a single file.