Fix rustix 0.38.42 build on riscv32 #1435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RISCV32 libc does not have these defines so use them from linux_raw_sys crate ioctl() signare does not match between musl and glibc ioctl is called the glibc way with ioctl(int, unsigned long int, ...), musl/POSIX has ioctl(int, int, ...) so address this as well
|
Thanks for the PR! However, I think in this case it's better to just fix the upstream libc crate to define these constants on riscv32. I've now submitted rust-lang/libc#4382 to do this. When I build rustix with a libc with that patch on riscv32gc-unknown-linux-gnu, it builds without any other modifications. |
|
rust-lang/libc#4382 is now landed, backported, and released in libc 0.2.172. I believe this fixes the underlying issue here; please file new issues if there are any further issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISCV32 libc does not have these defines so use them from linux_raw_sys crate
ioctl() signare does not match between musl and glibc ioctl is called the glibc way with ioctl(int, unsigned long int, ...), musl/POSIX has ioctl(int, int, ...)
so address this as well