feat: allow clients to pass extra-data for proof set creation and adding roots #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Apr 17, 2025
cmd/pdptool/main.go
Outdated
|
|
||
| // Load the private key (implement `loadPrivateKey` according to your setup) | ||
| // Validate extraData hex string and its decoded length | ||
| if extraDataHexStr != "" { |
There was a problem hiding this comment.
nit: extract to a small validation and decode function since we use this code a bunch
pdp/handlers.go
Outdated
| } | ||
| extraDataBytes = decodedBytes | ||
| } else { | ||
| extraDataBytes = []byte{} // Ensure it's an empty byte slice if not provided |
There was a problem hiding this comment.
nit: just initialize extraDataBytes := []byte{} on line 613. Then we can avoid the else statement
|
@ZenGround0 Addressed your changes and merging. Thanks. |
frrist
added a commit
to storacha/storage
that referenced
this pull request
Apr 23, 2025
- required by change in curio: filecoin-project/curio#480
frrist
added a commit
to storacha/storage
that referenced
this pull request
Apr 24, 2025
- required by change in curio: filecoin-project/curio#480 - add make directive for generating mocks
magik6k
added a commit
that referenced
this pull request
Apr 25, 2025
* pdp: Inital scaffold * pdp: Drop unneded handlers * pdp: wip uploads * pdp: Proper pieceref tracking * storage: Implement local stash storage * storage: Make Local use a single URL * pdp: Complete upload * piecepark: Special long-term storage mode * dealdata: Handle custore:// * pdp: Notify task * retrieval: Foundations for PiecePark readers * retrieval: Parked piece /piece retrievals * pdptool for interacting with curio pdp endpoints * pdp webui: Basic page, adding services through UI * pdp webui: Remove service button * get http server cert cache working * pdp: server and tool ping functionality * slowly getting data import to actually work * separate pdp task config * make gen * basic pdp key management * eth sender * more working pdp message sender * initial eth waiter * eth waiter fixes * wip impl /create-proofset * wire up proofset create * pdptool: Add a tool for proofset-create * gas estimation in eth sender * proofset receipt parsing * pdp: Endpoint to get proofset creation status * pdp: get-proof-set endpoint * pdp: Add-root endpoint * pdp: Separate table for root adds * pdp: Working root adds * pdp: Add-root watcher * pdp: working root adding * pdp: Watch challenge epochs * pdp: Scaffold prove task * pdp: Prove scheduling * pdp: Path from challenge to prove * proof: Sha memtree * proof: Binary memtree proover * pdp: Require sorted subroot pieces * pdp: Getting there with proof verification * pdp: Proof bugfixing progress * pdp: PROOFS WORK! * pdp: An actually working poller this time * pdp: better praams * pdp: Update contarcts * make gen, consistent max piece size * fix local path test * pdp: Implement fees * pdp chall lookback in prove * update to new proving scheme * small fixes * pdp: Support arbitrary hash funcs in uploads * pdp: api readme * fix lint * feat(pdp): add endpoint to poll for completed upload (#304) * feat(pdp): add handler to check for piece cid status * feat(pdp): add handler to check for upload exists * enable chain sched with just eth sender * feat(pdp): add ed25519 support for JWT (#323) Allows accepting JWTs that are signed with Ed25519 as well as ECDSA * fix(pdp): fix ed25519 auth (#324) x509 does not parse to pointer type on ed25519 * Zen/update interface (#334) * Update PDP to new proof scheduling WIP * add listener addr to pdp tables * generate bindings for new proving_schedule iface * Complete draft of new challenge window scheduling * Try to get tests building * No fancy ALTER tables * Review response * Fix * Fix sql syntax --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Integrate pdp updates -- nextProvingPeriod called after first add (#347) * Update contract wrappers * Update to pdp code freeze -- next pp now called after first add * Better initializing of init_ready flag * Name too long * Bad db select arg from copy paste * update pdp contract addr * Fix invalid insert statement * Remove unnecessary call that fails * Fix old sql error * SQL schema tweak * Fix write to bogus column * YASQLSE * DB scan param tweaking * Debuging bad call to listener * Lets try this * Fix attempt 1 * Safer init proving period challenge epoch * Less aggressive buffer * Print out init epoch * more logging * fix sql update bug * pass challenge epoch to pdptool * drand integration * flexible challenge window extension * Update contract abi * Update to refactored contract fee calc endpoint * Multiply by basefee * debug * Correct logging * Provide value during gas estimation * Tweak * Better understanding of proof fee * correct printing * more logging * bigger buffer * logging for debug of next pp * fix bug * Cleanup * Fix incorrect challenge range when adding new roots --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Delete pdp roots from proofset (#384) * Core api and prove task logic changes * Update pdptool to process deletes * SQL ordering fix * NoSQL just track removals on chain * Log removals * correct pdptool output * correct delete api interface * remove * remove * Update tasks/pdp/task_prove.go Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> * review response * Fix up --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> * make gen * drop some unused things * crypto rand in pdptool * reduce log verbosity, ethwaits index * Nice tool for pdp upload of large files (#397) * Refactoring * Debug * add piece upload command * Try this * bigger chunk size * Make all http server timeouts 2 hours * Parallel uploads 100MB chunk size, progress bar goroutine * revert parallel upload for simplicity * Upload tool Reuse connection * debug * Debugging failing proofs * More debug * deeper debug * more debug * more logging * this one weird fix * Clean upg * Respect config * Lint pass --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Feat/upload bigger than sector size (#435) * Support files bigger than 64 GiB * Put another print behind verbose * Account for padded size * debugging * Try this fix * Plausible fix so reinstating uploads * rewrite abi * debugging add root events * big debug * debug * Correctly use the add roots event * debug print event data * Fix type casting * correct indexing --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Fix/miner premium (#448) * Attempting lower premium * Fixup init * Use eth api premium estimation instead of lotus estimation --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Mainnet api and pdp addr (#464) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Do the correct thing (#465) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Merge/main into pdp (#471) * Fix Cleanup LID commands (#391) * fix slow message wait index (#392) * fix: seal: Check the correct column before assigning batch submit task (#394) * fix finalize ensureOne (#395) * Fix acme challenge (#398) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * feat: 'curio storage generate-vanilla-proof' command (#396) * proof command * fix randomness * fix: WinPoSt alert (#399) * webui: Show storage use breakdown by file type (#402) * webui: Show storage use breakdown by file type * make gen * add error return in DefaultAllowBehaviour (#404) * feat: gc: Mark snap sector key files for removal (#403) * feat: gc: Mark snap sector key files for removal * fix some panics * only mark snap keys which actually exist * cli: Add address filter flag to wdpost test * make gen * update translations * snap gc: one more redundant filter * snap gc: more conservative lookback * make gen * chore(deps): bump github.com/golang/glog from 1.2.0 to 1.2.4 (#390) Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.2.0 to 1.2.4. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.2.0...v1.2.4) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * GITBOOK-38: docs - how to be sp * fix commit param count (#406) * GITBOOK-39: update add-url docs * GITBOOK-40: update ipni docs * combine piecelocator endpoints (#408) * docs: Improve supraseal setup docs (#409) * docs: Improve supraseal setup docs * Update documentation/en/supraseal.md --------- Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> * GITBOOK-41: snap and batch updated * storage redeclare command (#410) * fix psd wait time column (#416) * fix: gc: Correctly calculate lookback (#418) * feat: spark contract (#377) * spark contract * add README, use correct key * make contract immutable * make gen * fix log fatal * fix ABI strings * serealize params * update contract getPeerData * update getPeerData return * update getPeerData return struct * fix retrun unpacking * update readme * some spack contract fixes * fix address conversion * log not updatin * pre-merge cleanup * switch signer to IPNI peerID * rename signedMessage to signature * Use mainnet verified contract --------- Co-authored-by: Łukasz Magiera <magik6k@gmail.com> * feat: devnet with market and deal client (#379) * devnet with market * update circleci check * please the linter gods * add ipni node * fix PieceLocator url * fix: improved PSD selection and findURL in market (#419) * better PSD selection and findURL * refactor psd creation * keep base layer updated with new config (#405) * keep base layer updated with new config * use transaction * ensure new keys are not removed by old nodes * remove commented code * harmony retry * feat: offline verified ddo deals (#417) * offline verified ddo deals * fix lint err * update yb version in circleci * add datacap * add allocate command * DDO UI, failure, db constraints * UI fixes, fix indexing for when should_index is false * fixes from testing * use lo filter * use should_index in query * release v1.24.5-rc1 (#420) * fix: improve filter (#421) * improve filter * fix allocate * GITBOOK-42: Market docs warning * release v1.24.5 (#422) * GITBOOK-43: deprecate boost adapter * feat: CID gravity connector (#407) * CID gravity connector * reorder internal filters * fix headers * add failure count * updated sealing states * struct to map for sealing states * sealing states to nested map * more error messages * fix error logging * send 0 when no storage * fix pipelineStats * fix state queries * fix http request creation * add request debugging log * add docs and UI * fix deal removal and list (#428) * Add Prometheus service discovery endpoint (#430) * Add Prometheus service discovery endpoint * fix: remove path * remove split layer * remove unsed header * fix lint * index sample command (#432) * fix: Update config comment with expected input and defaults (#427) * remove unused config, add default to comment * remove Duration completely * fix comment * fix lint version * fix: Correct supra single hasher core assignments (#426) * fix: supra: Correctly propagate hashers per thread config * fix hasher math * correct number in assign * multi token cid gravity (#433) * fix: mark deal sealed in a DB transaction (#434) * mark deal sealed in a DB transaction * fix deal seal sql func * better error logging * Add comments to SQL * update curio cli flags (#441) * update slack alert format (#423) * GITBOOK-45: update the installation page * bye bye circleci (#443) * bye bye circleci * remove circleci ref from README * no translation in test * run GA on all PR events (#445) * run GA on all push or PR events * remove all push event * CID Gravity handles backpressure rejection (#440) * CID Gravity handles backpressure * remove empty string arrays * option to bind TreeD to SDR node (#442) * SQL based batch creation (#438) * SQL based batch creation * remove update lock * feat: Balance Manager (#431) * MarketBalanceManager * fix name * small doc update * refactor balance manager * fix amount * Move balance manager to Address section * fix edge case * fix docs link * abtract toml fix in a function * feat: nv25 (#446) * feat: nv25 * update docs * menu drawer (#429) * feat: add Curio PDP docs (#447) * feat: add Curio PDP docs feat: add Curio PDP docs * chore: move to the experimental-features section chore: move to the experimental-features section * chroe: make durations human friendly chroe: make durations human friendly * chore: add links to installation and setup pages chore: add links to installation and setup pages * chore: add link to storage config page chore: add link to storage config page * chore: rename PDP-only SP to Curio PDP SP chore: rename PDP-only SP to Curio PDP SP * chore: add PDP page to the menu chore: add PDP page to the menu * make postgres load balance optional (#451) * fix: store log debug, seal poller log, batching, itest (#450) * store debug logs * fix pollerAddStartEpoch * drop NewMinerIDTest * add comments to poller checks * feat: add transfer type to cidgravity payload (#452) * GITBOOK-46: update PDP docs * fix keep unsealed for f05 deals (#459) * fix phantom IPNI tasks (#454) * fix cidgravity ipni and indexing value (#457) * fix UI wallet name on actor detail page (#455) * fix: panic in allocateToExisting (#460) * fix bulk pipeline restart (#458) * chore(deps): bump @babel/runtime in /market/ipni/spark/sol (#444) Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.26.0 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * release v1.25.0 (#456) * release v1.25.0 * update go-etherum * wallet friendly names (#317) * friendly wallet names * short name and clipboard copy --------- Co-authored-by: LexLuthr <lexluthr@curiostorage.org> * update lotus version for devnet, undo menu drawer (#461) * update lotus version for devnet, undo menu drawer * update GA files * roll new version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com> Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: Lee <octalgah@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mayank Pandey <mayank@curiostorage.org> Co-authored-by: Łukasz Magiera <magik6k@gmail.com> Co-authored-by: Phi-rjan <orjan.roren@gmail.com> Co-authored-by: Florian Ruen <florian.ruen@cidgravity.com> Co-authored-by: Andrew Jackson (Ajax) <snadrus@gmail.com> Co-authored-by: LexLuthr <lexluthr@curiostorage.org> * Merge/main into pdp again (#472) * Fix Cleanup LID commands (#391) * fix slow message wait index (#392) * fix: seal: Check the correct column before assigning batch submit task (#394) * fix finalize ensureOne (#395) * Fix acme challenge (#398) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * feat: 'curio storage generate-vanilla-proof' command (#396) * proof command * fix randomness * fix: WinPoSt alert (#399) * webui: Show storage use breakdown by file type (#402) * webui: Show storage use breakdown by file type * make gen * add error return in DefaultAllowBehaviour (#404) * feat: gc: Mark snap sector key files for removal (#403) * feat: gc: Mark snap sector key files for removal * fix some panics * only mark snap keys which actually exist * cli: Add address filter flag to wdpost test * make gen * update translations * snap gc: one more redundant filter * snap gc: more conservative lookback * make gen * chore(deps): bump github.com/golang/glog from 1.2.0 to 1.2.4 (#390) Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.2.0 to 1.2.4. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.2.0...v1.2.4) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * GITBOOK-38: docs - how to be sp * fix commit param count (#406) * GITBOOK-39: update add-url docs * GITBOOK-40: update ipni docs * combine piecelocator endpoints (#408) * docs: Improve supraseal setup docs (#409) * docs: Improve supraseal setup docs * Update documentation/en/supraseal.md --------- Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> * GITBOOK-41: snap and batch updated * storage redeclare command (#410) * fix psd wait time column (#416) * fix: gc: Correctly calculate lookback (#418) * feat: spark contract (#377) * spark contract * add README, use correct key * make contract immutable * make gen * fix log fatal * fix ABI strings * serealize params * update contract getPeerData * update getPeerData return * update getPeerData return struct * fix retrun unpacking * update readme * some spack contract fixes * fix address conversion * log not updatin * pre-merge cleanup * switch signer to IPNI peerID * rename signedMessage to signature * Use mainnet verified contract --------- Co-authored-by: Łukasz Magiera <magik6k@gmail.com> * feat: devnet with market and deal client (#379) * devnet with market * update circleci check * please the linter gods * add ipni node * fix PieceLocator url * fix: improved PSD selection and findURL in market (#419) * better PSD selection and findURL * refactor psd creation * keep base layer updated with new config (#405) * keep base layer updated with new config * use transaction * ensure new keys are not removed by old nodes * remove commented code * harmony retry * feat: offline verified ddo deals (#417) * offline verified ddo deals * fix lint err * update yb version in circleci * add datacap * add allocate command * DDO UI, failure, db constraints * UI fixes, fix indexing for when should_index is false * fixes from testing * use lo filter * use should_index in query * release v1.24.5-rc1 (#420) * fix: improve filter (#421) * improve filter * fix allocate * GITBOOK-42: Market docs warning * release v1.24.5 (#422) * GITBOOK-43: deprecate boost adapter * feat: CID gravity connector (#407) * CID gravity connector * reorder internal filters * fix headers * add failure count * updated sealing states * struct to map for sealing states * sealing states to nested map * more error messages * fix error logging * send 0 when no storage * fix pipelineStats * fix state queries * fix http request creation * add request debugging log * add docs and UI * fix deal removal and list (#428) * Add Prometheus service discovery endpoint (#430) * Add Prometheus service discovery endpoint * fix: remove path * remove split layer * remove unsed header * fix lint * index sample command (#432) * fix: Update config comment with expected input and defaults (#427) * remove unused config, add default to comment * remove Duration completely * fix comment * fix lint version * fix: Correct supra single hasher core assignments (#426) * fix: supra: Correctly propagate hashers per thread config * fix hasher math * correct number in assign * multi token cid gravity (#433) * fix: mark deal sealed in a DB transaction (#434) * mark deal sealed in a DB transaction * fix deal seal sql func * better error logging * Add comments to SQL * update curio cli flags (#441) * update slack alert format (#423) * GITBOOK-45: update the installation page * bye bye circleci (#443) * bye bye circleci * remove circleci ref from README * no translation in test * run GA on all PR events (#445) * run GA on all push or PR events * remove all push event * CID Gravity handles backpressure rejection (#440) * CID Gravity handles backpressure * remove empty string arrays * option to bind TreeD to SDR node (#442) * SQL based batch creation (#438) * SQL based batch creation * remove update lock * feat: Balance Manager (#431) * MarketBalanceManager * fix name * small doc update * refactor balance manager * fix amount * Move balance manager to Address section * fix edge case * fix docs link * abtract toml fix in a function * feat: nv25 (#446) * feat: nv25 * update docs * menu drawer (#429) * feat: add Curio PDP docs (#447) * feat: add Curio PDP docs feat: add Curio PDP docs * chore: move to the experimental-features section chore: move to the experimental-features section * chroe: make durations human friendly chroe: make durations human friendly * chore: add links to installation and setup pages chore: add links to installation and setup pages * chore: add link to storage config page chore: add link to storage config page * chore: rename PDP-only SP to Curio PDP SP chore: rename PDP-only SP to Curio PDP SP * chore: add PDP page to the menu chore: add PDP page to the menu * make postgres load balance optional (#451) * fix: store log debug, seal poller log, batching, itest (#450) * store debug logs * fix pollerAddStartEpoch * drop NewMinerIDTest * add comments to poller checks * feat: add transfer type to cidgravity payload (#452) * GITBOOK-46: update PDP docs * fix keep unsealed for f05 deals (#459) * fix phantom IPNI tasks (#454) * fix cidgravity ipni and indexing value (#457) * fix UI wallet name on actor detail page (#455) * fix: panic in allocateToExisting (#460) * fix bulk pipeline restart (#458) * chore(deps): bump @babel/runtime in /market/ipni/spark/sol (#444) Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.26.0 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * release v1.25.0 (#456) * release v1.25.0 * update go-etherum * wallet friendly names (#317) * friendly wallet names * short name and clipboard copy --------- Co-authored-by: LexLuthr <lexluthr@curiostorage.org> * update lotus version for devnet, undo menu drawer (#461) * update lotus version for devnet, undo menu drawer * update GA files * fix NV25 upgrade (#468) * fix batch build (#470) * go mod tidy * Correctly merge to sectorReader * Remove bad merge duplicate --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com> Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: Lee <octalgah@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mayank Pandey <mayank@curiostorage.org> Co-authored-by: Łukasz Magiera <magik6k@gmail.com> Co-authored-by: Phi-rjan <orjan.roren@gmail.com> Co-authored-by: Florian Ruen <florian.ruen@cidgravity.com> Co-authored-by: Andrew Jackson (Ajax) <snadrus@gmail.com> Co-authored-by: LexLuthr <lexluthr@curiostorage.org> * Feat/download file (#473) * Use better chunk size * Fix silly order of operations * Fix fix * Fix progress bar errors when file fits within one piece * Fix OBO * dry run and chunk file * pdptool download-file * lint --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * Connect to correct api for network (#477) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * feat: cors headers on http endpoint (#478) * gen, fix build * Get owner key for proofset from chain (#485) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> * feat: allow clients to pass extra-data for proof set creation and adding roots (#480) * pass extradata to Curio * changes as per review * make pdptool (#491) * Add maximum retries logic to PDP tasks (#496) * Add maximum retries logic Add maximum retries logic * Add maximum retries logic Add maximum retries logic * remove stale sql file * review addressing --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Hannah Howard <hannah@hannahhoward.net> Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com> Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> Co-authored-by: Lee <octalgah@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mayank Pandey <mayank@curiostorage.org> Co-authored-by: Phi-rjan <orjan.roren@gmail.com> Co-authored-by: Florian Ruen <florian.ruen@cidgravity.com> Co-authored-by: Andrew Jackson (Ajax) <snadrus@gmail.com> Co-authored-by: LexLuthr <lexluthr@curiostorage.org> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com> Co-authored-by: TippyFlits <james@filoz.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PDPVerifiercontract allows passing an opaque byte array as "extradata" that gets passed to the listener as is. This is needed for allowing the client/provider to pass in payer/payee addresses and proofset/root metadata to the listener to build payment flows/better explorer UX.