[NVPTX] Remove extraneous initializeNVVMReflectLegacyPassPass declaration #135825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-nvptx Author: Yonah Goldberg (YonahGoldberg) ChangesThis was already declared in NVPTX.h and I accidentally added it back in #134416. Full diff: https://github.com/llvm/llvm-project/pull/135825.diff 1 Files Affected:
diff --git a/llvm/lib/Target/NVPTX/NVVMReflect.cpp b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
index 7273b30e4ae2e..30b522efa4361 100644
--- a/llvm/lib/Target/NVPTX/NVVMReflect.cpp
+++ b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
@@ -52,10 +52,6 @@ using namespace llvm;
#define DEBUG_TYPE "nvvm-reflect"
-namespace llvm {
-void initializeNVVMReflectLegacyPassPass(PassRegistry &);
-} // namespace llvm
-
namespace {
class NVVMReflect {
// Map from reflect function call arguments to the value to replace the call
|
Artem-B
approved these changes
Apr 15, 2025
|
Merging on behalf of @YonahGoldberg at his request offline. |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…tion (llvm#135825) This was already declared in NVPTX.h and I accidentally added it back in llvm#134416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already declared in NVPTX.h and I accidentally added it back in #134416.