chore(test): migrate from Jest to `node:test` #7623

avivkeller · 2025-04-05T15:40:55Z

This PR replaces Jest with node:test as the test runner. ~~While it's currently marked as a draft, it's functionally complete (aside from some GitHub Actions that still need testing), so feel free to review it as you would a regular PR.~~

The new setup uses node:test with tsx, global-jsdom, and custom mocks located in apps/site/tests/mocks and /tests/mocks. The root-level mocks are shared across multiple packages.

vercel · 2025-04-05T15:41:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Apr 17, 2025 3:28pm

avivkeller · 2025-04-05T15:55:39Z

https://github.com/nodejs/nodejs.org/actions/runs/14283482781/job/40035760995#step:7:27 🤔

tests/loader.mjs

tests/utilities.mjs

AugustinMauroy

first batch of review mainly on test env

tests/setup.mjs

packages/ui-components/package.json

apps/site/package.json

.github/workflows/lint-and-tests.yml

AugustinMauroy · 2025-04-05T16:23:49Z

also instead of import assert from 'node:assert'; you should use the strict version import assert from 'node:assert/strict';.

maybe take a look for an eslint rule

avivkeller · 2025-04-05T19:03:19Z

Blocked by nodejs/admin#964. Once we get codecov setup, i'll add the action into the PR.

ovflowd · 2025-04-07T08:31:35Z

github-actions · 2025-04-07T08:31:48Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

.github/workflows/lint-and-tests.yml

package.json

apps/site/tests/loader.mjs

avivkeller · 2025-04-17T13:57:31Z

(Misclick w/ the auto merge, meant to click on the reviews 😅)

ovflowd

I think we can get this merged. Although I'd like a codecov preview and maybe confirmation CI will work as expected.

avivkeller · 2025-04-17T14:24:10Z

I'd like a codecov preview

#7623 (comment)
https://app.codecov.io/github/nodejs/nodejs.org/tree/jest-to-node-test

and maybe confirmation CI will work as expected.

https://github.com/nodejs/nodejs.org/actions/runs/14517876700/job/40731263794?pr=7623
https://github.com/nodejs/nodejs.org/actions/runs/14517876700/job/40731263071?pr=7623

I'll manually deploy a storybook momentarily

This reverts commit ea2b8b1.

avivkeller · 2025-04-17T14:31:22Z

Storybook (via new workflow):
https://www.chromatic.com/build?appId=64c7d71358830e9105808652&number=2735

canerakdas

I tested it locally on macOS and added a few minor comments regarding the import order and grouping. Overall, it looks awesome 🤩

apps/site/components/Blog/BlogPostCard/__tests__/index.test.jsx

apps/site/hooks/react-client/__tests__/useClientContext.test.jsx

apps/site/hooks/react-client/__tests__/useCopyToClipboard.test.jsx

apps/site/hooks/react-client/__tests__/useNotification.test.jsx

apps/site/providers/__tests__/matterProvider.test.jsx

packages/ui-components/Common/BasePagination/PaginationListItem/__tests__/index.test.jsx

packages/ui-components/Common/BasePagination/__tests__/index.test.jsx

packages/ui-components/Common/Tabs/__tests__/index.test.jsx

packages/ui-components/Common/ThemeToggle/__tests__/index.test.jsx

packages/ui-components/Containers/MetaBar/__tests__/index.test.jsx

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Aviv Keller <me@aviv.sh>

avivkeller · 2025-04-17T17:52:25Z

🫡🥂

Follow-up actions:

chromatic should be designated a required status check
Codecov should be enabled on the repository as an app. Until then, @codecov-commenter will leave the comments

bmuenzenmeyer · 2025-04-17T18:12:07Z

[ ] chromatic should be designated a required status check

does this look right?

avivkeller · 2025-04-17T18:23:44Z

Yep!

avivkeller force-pushed the jest-to-node-test branch from fd17503 to 08785ef Compare April 5, 2025 15:42

vercel bot deployed to Preview April 5, 2025 15:44 View deployment

avivkeller had a problem deploying to Storybook April 5, 2025 15:46 — with GitHub Actions Failure

vercel bot deployed to Preview April 5, 2025 15:47 View deployment

avivkeller had a problem deploying to Storybook April 5, 2025 15:53 — with GitHub Actions Failure

vercel bot deployed to Preview April 5, 2025 15:53 View deployment

AugustinMauroy reviewed Apr 5, 2025

View reviewed changes

tests/loader.mjs Show resolved Hide resolved

AugustinMauroy reviewed Apr 5, 2025

View reviewed changes

tests/utilities.mjs Show resolved Hide resolved

avivkeller deployed to Storybook April 5, 2025 16:10 — with GitHub Actions Active

vercel bot deployed to Preview April 5, 2025 16:10 View deployment

AugustinMauroy reviewed Apr 5, 2025

View reviewed changes

tests/setup.mjs Show resolved Hide resolved

packages/ui-components/package.json Outdated Show resolved Hide resolved

apps/site/package.json Outdated Show resolved Hide resolved

.github/workflows/lint-and-tests.yml Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 5, 2025 16:26 View deployment

avivkeller linked an issue Apr 5, 2025 that may be closed by this pull request

Switch from Jest to Node.js's Native Test Runner #6123

Closed

avivkeller mentioned this pull request Apr 5, 2025

Switch from Jest to Node.js's Native Test Runner #6123

Closed

avivkeller added the blocked label Apr 5, 2025

ovflowd added the github_actions:pull-request label Apr 7, 2025

github-actions bot removed the github_actions:pull-request label Apr 7, 2025

ovflowd deployed to Storybook April 7, 2025 08:31 — with GitHub Actions View deployment

ovflowd reviewed Apr 7, 2025

View reviewed changes

.github/workflows/lint-and-tests.yml Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

ovflowd reviewed Apr 7, 2025

View reviewed changes

package.json Show resolved Hide resolved

ovflowd reviewed Apr 7, 2025

View reviewed changes

package.json Show resolved Hide resolved

ovflowd reviewed Apr 7, 2025

View reviewed changes

apps/site/tests/loader.mjs Show resolved Hide resolved

avivkeller force-pushed the jest-to-node-test branch from 40550ed to 2466a6e Compare April 8, 2025 00:16

avivkeller disabled auto-merge April 17, 2025 13:57

ovflowd approved these changes Apr 17, 2025

View reviewed changes

document custom loader

7296d82

vercel bot deployed to Preview April 17, 2025 14:22 View deployment

[tmp, verify storybook]

ea2b8b1

vercel bot deployed to Preview April 17, 2025 14:26 View deployment

Revert "[tmp, verify storybook]"

977a7b6

This reverts commit ea2b8b1.

vercel bot deployed to Preview April 17, 2025 14:28 View deployment

avivkeller added the github_actions:pull-request label Apr 17, 2025

avivkeller deployed to Storybook April 17, 2025 14:31 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request label Apr 17, 2025

avivkeller mentioned this pull request Apr 17, 2025

Get Code Coverage >= 90% #7657

Open

3 tasks

canerakdas reviewed Apr 17, 2025

View reviewed changes

Apply suggestions from code review

7f429d2

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Aviv Keller <me@aviv.sh>

vercel bot deployed to Preview April 17, 2025 15:25 View deployment

Apply suggestions from code review

57967c1

avivkeller added the github_actions:pull-request label Apr 17, 2025

avivkeller deployed to Storybook April 17, 2025 15:27 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request label Apr 17, 2025

vercel bot deployed to Preview April 17, 2025 15:28 View deployment

avivkeller added this pull request to the merge queue Apr 17, 2025

Merged via the queue into main with commit 162cd26 Apr 17, 2025
17 checks passed

avivkeller deleted the jest-to-node-test branch April 17, 2025 17:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(test): migrate from Jest to `node:test` #7623

chore(test): migrate from Jest to `node:test` #7623

avivkeller commented Apr 5, 2025 •

edited

Loading

vercel bot commented Apr 5, 2025 •

edited

Loading

avivkeller commented Apr 5, 2025

AugustinMauroy left a comment

AugustinMauroy commented Apr 5, 2025

avivkeller commented Apr 5, 2025 •

edited

Loading

ovflowd commented Apr 7, 2025

github-actions bot commented Apr 7, 2025 •

edited

Loading

This comment was marked as resolved.

avivkeller commented Apr 17, 2025

ovflowd left a comment

avivkeller commented Apr 17, 2025

avivkeller commented Apr 17, 2025 •

edited

Loading

canerakdas left a comment

avivkeller commented Apr 17, 2025 •

edited

Loading

bmuenzenmeyer commented Apr 17, 2025

avivkeller commented Apr 17, 2025

chore(test): migrate from Jest to node:test #7623

chore(test): migrate from Jest to node:test #7623

Conversation

avivkeller commented Apr 5, 2025 • edited Loading

vercel bot commented Apr 5, 2025 • edited Loading

avivkeller commented Apr 5, 2025

AugustinMauroy left a comment

Choose a reason for hiding this comment

AugustinMauroy commented Apr 5, 2025

avivkeller commented Apr 5, 2025 • edited Loading

ovflowd commented Apr 7, 2025

github-actions bot commented Apr 7, 2025 • edited Loading

This comment was marked as resolved.

avivkeller commented Apr 17, 2025

ovflowd left a comment

Choose a reason for hiding this comment

avivkeller commented Apr 17, 2025

avivkeller commented Apr 17, 2025 • edited Loading

canerakdas left a comment

Choose a reason for hiding this comment

avivkeller commented Apr 17, 2025 • edited Loading

🫡🥂

bmuenzenmeyer commented Apr 17, 2025

avivkeller commented Apr 17, 2025

chore(test): migrate from Jest to `node:test` #7623

chore(test): migrate from Jest to `node:test` #7623

avivkeller commented Apr 5, 2025 •

edited

Loading

vercel bot commented Apr 5, 2025 •

edited

Loading

avivkeller commented Apr 5, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

avivkeller commented Apr 17, 2025 •

edited

Loading

avivkeller commented Apr 17, 2025 •

edited

Loading