Skip to content

feat(download): include link to releases about page from downloads #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

MattIPv4
Copy link
Member

Description

Includes a link on the main download page to the about page covering release cycles et al. to help with discovery of this page when users are looking at what version of Node.js to get started with.

Validation

Access /download, confirm link to /about/previous-releases present and works.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 22:41
@MattIPv4 MattIPv4 requested a review from a team as a code owner April 15, 2025 22:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • apps/site/pages/en/download/current.mdx: Language not supported
  • apps/site/pages/en/download/index.mdx: Language not supported

Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 15, 2025 10:52pm

Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
Copy link
Contributor

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
96.17% (176/183) 78.67% (107/136) 89.74% (35/39)
@nodejs/website Coverage: 87%
84.7% (493/582) 76.03% (165/217) 86.88% (106/122)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 31 0 💤 0 ❌ 0 🔥 4.807s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.302s ⏱️

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 85 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit e2cf169 Apr 17, 2025
15 checks passed
@avivkeller avivkeller deleted the MattIPv4/download-link-about branch April 17, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants