-
Notifications
You must be signed in to change notification settings - Fork 110
TST: enable CPython free-threading support #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @andfoy. Mostly looks good, a few comments.
I have approved the workflows, so now the CI will run here! |
c87fc40
to
c3e5783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy, this LGTM now. The changes are very minimal, and I verified locally too that everything works as advertised, both with and without pytest-run-parallel
installed.
I confirm wheels are building locally: https://github.com/andfoy/bottleneck/actions/runs/14230390834 |
I need to push a final commit, and it should be ready to go |
Why are we skipping |
I bet it's because |
This is the actual issue at hand, since the job is only failing on free-threaded builds under x86, I decided to skip them for now. |
@andfoy the failure caught a problem. It looks like a cross-merge conflict because Keeping the traceback for posterity:
|
I confirm that |
@andfoy now that the new |
ed8e058
to
509050d
Compare
This PR enables free-threading builds of bottleneck, available from Python 3.13 onwards, this new distribution allows Python packages to leverage true parallel support, as the GIL is now optional.
In particular, this PR performs the following checks:
pytest-run-parallel
, which allows pytest suites to be run concurrently (per test). This analysis didn't throw any major concurrency-related issues, the only tests that were marked as thread-unsafe were related to memory usage checking and concurrent file overwriting.