Skip to content

Fix broken Sphinx Roles #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix broken Sphinx Roles #10225

merged 2 commits into from
Apr 16, 2025

Conversation

philipc2
Copy link
Contributor

@philipc2 philipc2 commented Apr 14, 2025 •
edited
Loading

@dcherian dcherian enabled auto-merge (squash) April 14, 2025 17:12
@philipc2 philipc2 marked this pull request as draft April 14, 2025 17:12
auto-merge was automatically disabled April 14, 2025 17:12

Pull request was converted to draft

@philipc2
Copy link
Contributor Author

philipc2 commented Apr 14, 2025 •
edited
Loading

Going to do another sweep and see if there are any other spots where this occurs.

EDIT: Seems to be good, couldn't find any other spots where they were broken other than these four.

@philipc2 philipc2 changed the title Fix broken Sphinx Roles due to missing leading colon Fix broken Sphinx Roles Apr 14, 2025
mathause
mathause approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. lgtm! I guess you can un-draft the PR?

@philipc2 philipc2 marked this pull request as ready for review April 15, 2025 10:23
@philipc2
Copy link
Contributor Author

Thanks. lgtm! I guess you can un-draft the PR?

Ooops, you're right!

@mathause mathause added the plan to merge Final call for comments label Apr 15, 2025
@mathause mathause merged commit 72ffff5 into pydata:main Apr 16, 2025
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Colons in front of Sphinx Roles
2 participants
@philipc2 @mathause