Move away from hoverxrefs #3245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've clicked the relevant buttons in the RTD UI and checked that:
The latter one works but the former one has 2 hover pop-ups. I'm not really sure how we can migrate gracefully, might be worth asking. For now I've disabled the link preview addon again. |
|
Might want to just wait until we're releasing a new build, then merge just before. |
|
Yeah that will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3244
As far as I can tell, this requires someone to press buttons in the RTD UI so it's not too useful to leave this up for someone new to Trio to fix.