For #script-closable, clarify when a browsing context is created by script #11208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
approved these changes
Apr 16, 2025
annevk
reviewed
Apr 16, 2025
source
Outdated
| @@ -99528,6 +99536,8 @@ interface <dfn interface>NotRestoredReasons</dfn> { | |||
|
|
|||
| <li><p>An <dfn>is auxiliary</dfn> boolean, initially false.</p></li> | |||
|
|
|||
| <li><p>An <dfn>is created by web content</dfn> boolean, initially false.</p></li> | |||
There was a problem hiding this comment.
Does it make sense for this to live on the browsing context? Once there's a COOP-style navigation the tab can no longer be closed?
There was a problem hiding this comment.
Ah, I think browsers behave in such a way that windows are still script-closable after COOP-style navigations.
Would it be better for the flag to be on Navigable?
There was a problem hiding this comment.
Yeah, I think in that case it would be.
@domenic or @jakearchibald should probably review as well given that.
There was a problem hiding this comment.
I made the change and will look into writing a test for this.
annevk
approved these changes
Apr 17, 2025
domenic
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an "is created by web content" flag on browsing contexts to determine script-closability. This flag is set when a new top-level traversable is created as a result of window.open(), link navigation, or form submission.
In reference to #1866.
(See WHATWG Working Mode: Changes for more details.)
cc @zcorpan
/document-sequences.html ( diff )
/nav-history-apis.html ( diff )