Skip to content

Commit

Permalink
Merge pull request #2 from codebrick-corp/feat-add-identifier
Browse files Browse the repository at this point in the history
added an identifier for dms task to metric label
  • Loading branch information
estherk0 committed May 9, 2022
2 parents 82c16dd + 58b4945 commit 34b318f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions README.md
Expand Up @@ -43,11 +43,11 @@ Belows are the list of metrics that `aws-dms-task-exporter` exports.
Sample metrics
```
# TYPE dms_task_stats gauge
dms_task_stats{action="delete",region="ap-southeast-1",schema="example_schema",table="inventories"} 40601
dms_task_stats{action="insert",region="ap-southeast-1",schema="example_schema",table="inventories"} 4.145428e+06
dms_task_stats{action="update",region="ap-southeast-1",schema="example_schema",table="inventories"} 1.24051e+06
dms_task_stats{action="delete",region="ap-southeast-1",identifier="inventory-change-task",schema="example_schema",table="inventories"} 40601
dms_task_stats{action="insert",region="ap-southeast-1",identifier="inventory-change-task",schema="example_schema",table="inventories"} 4.145428e+06
dms_task_stats{action="update",region="ap-southeast-1",identifier="inventory-change-task",schema="example_schema",table="inventories"} 1.24051e+06
```

Name | Description | Labels
-----|-----|-----
dms_task_stats | DMS Task Table Statistics showing counts of Insert, Delete, Update of source tables | action, region, schema, table
dms_task_stats | DMS Task Table Statistics showing counts of Insert, Delete, Update of source tables | action, region, schema, table, identifier
8 changes: 4 additions & 4 deletions aws-dms-task-exporter.go
Expand Up @@ -18,7 +18,7 @@ var (
MetricName = "task_stats"
MetricNamespace = "dms"
MetricHelpMessage = "Gauge for dms tasks statistics"
MetricLabels = []string{"region", "schema", "table", "action"}
MetricLabels = []string{"region", "identifier", "schema", "table", "action"}
)

type collector struct {
Expand Down Expand Up @@ -106,9 +106,9 @@ func (c *collector) fetch(gauge *prometheus.GaugeVec) {
continue
}
for _, stat := range stats {
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *stat.schemaName, *stat.tableName, "insert").Set(float64(*stat.inserts))
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *stat.schemaName, *stat.tableName, "delete").Set(float64(*stat.deletes))
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *stat.schemaName, *stat.tableName, "update").Set(float64(*stat.updates))
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *task.identifier, *stat.schemaName, *stat.tableName, "insert").Set(float64(*stat.inserts))
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *task.identifier, *stat.schemaName, *stat.tableName, "delete").Set(float64(*stat.deletes))
gauge.WithLabelValues(viper.GetString("AWS_REGION"), *task.identifier, *stat.schemaName, *stat.tableName, "update").Set(float64(*stat.updates))
}
}
}
Expand Down

0 comments on commit 34b318f

Please sign in to comment.