Fix table row indices to handle headers and footers correctly #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyziq
changed the title
nank1ro
requested changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where row indices do not start from 0 when using headers in the
ShadTablecomponent. The changes ensure that the effective row count is calculated correctly and that row indices are adjusted accordingly.Changes:
effectiveRowCountto account for headers and footers.cellBuilderto correctly adjust row indices when a header is present.Issue Reference:
closes #66
Testing:
Tested with a table that includes headers and footers to ensure all rows are displayed correctly.