Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/signal autodispose observation #84

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

nank1ro
Copy link
Owner

@nank1ro nank1ro commented Dec 19, 2023

fix autoDispose of signal with observations

@nank1ro nank1ro self-assigned this Dec 19, 2023
@nank1ro nank1ro added the bug Something isn't working label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #84 (e0e607c) into main (f46b91d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1244      1243    -1     
=========================================
- Hits          1244      1243    -1     
Files Coverage Δ
packages/solidart/lib/src/core/atom.dart 100.00% <100.00%> (ø)
packages/solidart/lib/src/core/effect.dart 100.00% <ø> (ø)
...ckages/solidart/lib/src/core/reactive_context.dart 100.00% <ø> (ø)
packages/solidart/lib/src/core/read_signal.dart 100.00% <100.00%> (ø)

@nank1ro nank1ro merged commit 0dd5e2c into main Dec 19, 2023
3 checks passed
@nank1ro nank1ro deleted the bugfix/signal-autodispose-observation branch December 19, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant