many changes preparing for 2.4.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was that when running stow_contents/unstow_contents recursively from stow_node/unstow_node the information for the source path (without the dot- to . transformation) was lost. In the case of stow_contents the solution is just to remove the leading dots (..) from the $source path (since the $source path is passed as an argument to the function) In the case of unstow_contents the solution is the same as for stow_contents but the arguments was now passed so I added it to the function.
This variables is used to keep track of the current level in the source.
This only updates copyright notices to 2020, and URLs to https.
gmane has been dead for quite a while:
https://lars.ingebrigtsen.no/2020/01/06/whatever-happened-to-news-gmane-org/
We no longer need to ensure that texi2any (a.k.a. makeinfo) is called
with -I $(srcdir) in order to make the
@verbatiminclude default-ignore-list
in the manual work, because texi2any includes the current working
directory by default anyway. Presumably this behaviour was introduced
after this AM_MAKEINFOFLAGS was previously added, because it was
needed at some point in the past.
We actually override check-TESTS.
Allow easy navigation to function definitions in emacs. The rg (ripgrep) search is needed because as the dumb-jump README says: [...] the default searcher (git-grep) won't be able to search outside of the project root. This edge case will be fixed in a future release. See: https://github.com/jacktasia/dumb-jump
And add some debug.
These don't add much value, and the reference to $source was out of date anyway.
The use of the word "source" is confusing in the context of Stow for reasons explained in the manual.
The use of the word "source" to describe a link's destination is confusing in the context of Stow for reasons explained in the manual. So rename the $existing_source variable to $link_dest avoid this.
Unqualified references to "path" are horribly vague, so rename to $existing_pkg_path_from_cwd for clarity.
These helpers can be called at more deeply nested levels, so they should be indented more than they were.
Remove old XXX FIXMEs which tell us nothing useful and may not be relevant any more. Also rename another XXX to an industry-standard FIXME.
The use of the word "source" to describe a link's destination is confusing in the context of Stow for reasons explained in the manual. So rename the $source variable to avoid this.
Unqualified references to "path" are horribly vague, so rename to $existing_pkg_path_from_cwd for clarity.
Unqualified references to "path" are horribly vague, so rename to $existing_pkg_path_from_cwd for clarity.
$parent is a bit vague so rename to $parent_in_pkg.
$source is vague and confusing as per the manual.
$target is vague and could refer to the top-level target directory, so rename to clarify.
is_a_node(), is_a_dir(), is_a_link() all operate on paths within the target directory, so make this explicit by avoiding the vague variable name "$path".
$target was the source of the link, and $source was the target (destination) of the link. Obviously this was hopelessly confusing, so rename to avoid this.
The STDERR capturing in testutil just reinvents Test::Output which we already use in chkstow.t, so it's pointless to reinvent that wheel.
This is better because it outputs the mismatching values when the equality check fails.
This is better because it outputs the mismatching value when the matching check fails.
This makes behaviour more deterministic, and makes debugging easier.
This reverts commit 1a20a3f. It turns out that `texi2dvi` _does_ require `-I $(srcdir)` for `@verbatiminclude default-ignore-list` to work after all. It's needed not for a normal docs build, but when `make distcheck` is run, presumably because `distcheck` runs from a different directory.
This reverts commit 5d4e682. It turns out that this broke `make distcheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this is mainly a test to see whether the new GitHub CI works.See
NEWSfor a summary of the changes.