Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar updated to match dark color aesthetic for dark mode #144

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

gjyotk
Copy link
Contributor

@gjyotk gjyotk commented Oct 28, 2023

Fixes Issue🛠️

Closes #143

Description👨‍💻

Here, I am updating the Scrollbar to match the dark-coloured-aesthetic when the dark mode is turned on by the user. This will enhance its visibility and improve the overall user experience.

  • Updation in UI to maintain the dark-theme in scrollbar when using dark mode
  • Enhance user experience of the website

Type of change📄

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

I have tested this enhancement on my local device to ensure an improved theme aesthetic and better user experience. Any more suggestions are welcome.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2023-10-29 at 12 24 14 PM Screenshot 2023-10-29 at 12 17 29 PM

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for click-the-edible-game ready!

Name Link
🔨 Latest commit 6e3d70c
🔍 Latest deploy log https://app.netlify.com/sites/click-the-edible-game/deploys/653e008fbb850700081fa7c0
😎 Deploy Preview https://deploy-preview-144--click-the-edible-game.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Can you pls change the color contrast of scrollbar thumb and track accordingly as they are not visibled properly @gjyotk

@Rakesh9100 Rakesh9100 changed the title update in Scrollbar to match dark-colour-aesthetic for dark mode Update in Scrollbar to match dark-colour-aesthetic for dark mode Oct 29, 2023
@Rakesh9100
Copy link
Owner

Looks good, Merged!! 🎉

@Rakesh9100 Rakesh9100 merged commit 8bdb367 into Rakesh9100:main Oct 29, 2023
4 checks passed
@Rakesh9100
Copy link
Owner

give @gjyotk 25 points

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program labels Oct 29, 2023
@gjyotk
Copy link
Contributor Author

gjyotk commented Oct 29, 2023

ThankYou!

@Rakesh9100 Rakesh9100 changed the title Update in Scrollbar to match dark-colour-aesthetic for dark mode Updated Scrollbar to match dark color aesthetic for dark mode Feb 18, 2024
@Rakesh9100 Rakesh9100 changed the title Updated Scrollbar to match dark color aesthetic for dark mode Scrollbar updated to match dark color aesthetic for dark mode Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for scrollbar in dark mode
2 participants