Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown server if servant obj not found in config file #193

Closed
defool opened this issue Apr 27, 2020 · 0 comments
Closed

Shutdown server if servant obj not found in config file #193

defool opened this issue Apr 27, 2020 · 0 comments

Comments

@defool
Copy link
Collaborator

defool commented Apr 27, 2020

https://github.com/TarsCloud/TarsGo/blob/master/tars/application.go#L283
This line ignore the error, which could cause unpredictable problem.
So I suggest to use teerDown function to shutdown server and send a notify message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@defool