Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use yaml or toml for conf file #257

Closed
WLun001 opened this issue Nov 13, 2020 · 2 comments
Closed

use yaml or toml for conf file #257

WLun001 opened this issue Nov 13, 2020 · 2 comments

Comments

@WLun001
Copy link

WLun001 commented Nov 13, 2020

this is the current conf file, which I think very hard to read

<tars>
  <application>
    <server>
       #each adapter configuration 
       <TestApp.HelloServer.HelloObjAdapter>
            #allow Ip for white list.
            allow
            # ip and port to listen on  
            endpoint=tcp -h 10.120.129.226 -p 20001 -t 60000
            #handlegroup
            handlegroup=TestApp.HelloServer.HelloObjAdapter
            #max connection 
            maxconns=200000
            #portocol, only tars for now.
            protocol=tars
            #max capbility in handle queue.
            queuecap=10000
            #timeout in ms for the request in the queue.
            queuetimeout=60000
            #servant 
            servant=TestApp.HelloServer.HelloObj
            #threads in handle server side implement code. goroutine for golang.
            threads=5
       </TestApp.HelloServer.HelloObjAdapter>
    </server>
  </application>
</tars>

Proposed config file

server:
  TestApp.HelloServer.HelloObjAdapter: 
     allow: true
      ....
@WLun001 WLun001 changed the title use yaml or tomml for conf file use yaml or toml for conf file Nov 13, 2020
@ruanshudong
Copy link
Contributor

This configuration format is consistent with other language service frameworks, so it is not easy to change to yaml

@WLun001
Copy link
Author

WLun001 commented Nov 15, 2020

unfortunately, these xml attributes are so hard to read

@WLun001 WLun001 closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants