Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) improve err message if $HOME is not defined #1664

Merged
merged 2 commits into from Mar 11, 2021
Merged

fix(kuma-cp) improve err message if $HOME is not defined #1664

merged 2 commits into from Mar 11, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

If $HOME is not defined error message will look like this:

Error: failed to create working directory inside $HOME: $HOME is not defined, please pick a working directory by setting KUMA_GENERAL_WORK_DIR manually

Documentation

  • no docs

@lobkovilya
fix(kuma-cp) improve err message if $HOME is not defined
c99f406 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner March 11, 2021 07:52
@lobkovilya
fix(kuma-cp) make check
ccc2671 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@nickolaev nickolaev merged commit b953e06 into master Mar 11, 2021
@nickolaev nickolaev deleted the fix/improve-err-msg branch March 11, 2021 09:23
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
@lobkovilya
fix(kuma-cp) improve err message if $HOME is not defined (#1664)
4cf14c4 
* fix(kuma-cp) improve err message if $HOME is not defined

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit b953e06)
@mergify mergify bot mentioned this pull request Mar 11, 2021
Merged
nickolaev pushed a commit that referenced this pull request Mar 11, 2021
@mergify @lobkovilya
fix(kuma-cp) improve err message if $HOME is not defined (#1664) (#1670)
edc7985 
* fix(kuma-cp) improve err message if $HOME is not defined

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit b953e06)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @nickolaev