feat(kmesh-cp) add kubernetes tags automatically #3439
Conversation
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
force-pushed
the
feat/kube-tags
branch
from
4815544
to
8f1a8df
Compare
| @@ -12,6 +12,8 @@ import ( | |||
| util_k8s "github.com/kumahq/kuma/pkg/plugins/runtime/k8s/util" | |||
| ) | |||
|
|
|||
| const NamespaceTag = "k8s.kuma.io/namespace" | |||
There was a problem hiding this comment.
Can't we add a k8s.kuma.io/port the point was to be able to use the port in virtual-outbound.
There was a problem hiding this comment.
And maybe k8s.kuma.io/service which is the serviceName in k8s. That way you have the info in kuma.io/service in separate tags.
Usage of k8s.kuma.io/service would be for example adding policy to services exposed on all pods (.e.g metrics)
There was a problem hiding this comment.
@jakubdyszkiewicz said:
I think that k8s.kuma.io/port is a bit generic. It always raises the question of “but what port?“. Should this be k8s.kuma.io/service-port?
I don't really mind either way so if you think service-port is better go for it!
There was a problem hiding this comment.
added. I also put k8s.kuma.io/service-name. Although -name suffix sounds redundant, I find k8s.kuma.io/service to be too close to kuma.io/service
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
force-pushed
the
feat/kube-tags
branch
from
aeed20c
to
a8cc1ce
Compare
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 19b4a04) # Conflicts: # pkg/plugins/runtime/k8s/controllers/inbound_converter.go
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Summary
Add
k8s.kuma.io/namespacetag automatically so we can build policy based on it.Issues resolved
Fix #3367
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.