-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): move adminPort to DPP resource #3739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lobkovilya
changed the title
feat(*) move adminPort to DPP resource
feat(*): move adminPort to DPP resource
Jan 24, 2022
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #3739 +/- ##
==========================================
+ Coverage 50.98% 51.01% +0.02%
==========================================
Files 930 934 +4
Lines 57260 57403 +143
==========================================
+ Hits 29196 29283 +87
- Misses 25743 25780 +37
- Partials 2321 2340 +19
Continue to review full report at Codecov.
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Jan 26, 2022
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
michaelbeaumont
force-pushed
the
feat/move-admin-port-to-dpp-res
branch
from
January 26, 2022 16:17
d02a967
to
13c4e5a
Compare
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lahabana
reviewed
Jan 27, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today Control Planes don't have an information on admin port in general. Technically adminPort could be looked up through xDS metadata for connected DPPs, but that's not enough if we want to expose
/config_dump
though Control Plane API. That's why current PR moves the source of truth for admin port fromkuma-dp run
flags to DPP resource:The same is applicable for ZoneIngress.
Full changelog
kuma-dp run
to get adminPort for MetricsHijackeradmin
section both for DPP and ZoneIngress resources--admin-port
flag for kuma-dpKUMA_DATAPLANE_ADMIN_PORT
for kuma-dpKUMA_RUNTIME_KUBERNETES_INJECTOR_SIDECAR_CONTAINER_ADMIN_PORT
for kuma-cp (since it duplicatesKUMA_BOOTSTRAP_SERVER_PARAMS_ADMIN_PORT
)kuma.io/envoy-admin-port
Issues resolved
Fix #3717
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy