Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove literals passed to device_uvector::set_element_async #1453

Merged
merged 1 commit into from Mar 17, 2021
Merged

Remove literals passed to device_uvector::set_element_async #1453

merged 1 commit into from Mar 17, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Mar 16, 2021

After rapidsai/rmm#725 is merged, this PR updates cuspatial to eliminate passing literal values to device_uvector::set_element_async.

Companion PR to rapidsai/cuspatial#367

@harrism harrism requested a review from a team as a code owner March 16, 2021 03:35
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 16, 2021
@BradReesWork BradReesWork added this to PRs in v0.19 Release Mar 16, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 16, 2021
@BradReesWork BradReesWork added DO NOT MERGE Hold off on merging; see PR for details Blocked Cannot progress due to external reasons labels Mar 16, 2021
seunghwak
seunghwak approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

afender
afender approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark.

@harrism
Copy link
Member Author

harrism commented Mar 17, 2021

codecov failing to connect in CI?

@harrism
Copy link
Member Author

harrism commented Mar 17, 2021

rerun tests

@harrism
Copy link
Member Author

harrism commented Mar 17, 2021

@BradReesWork this should be safe to merge and good to get it in before RMM #725 merges. Why the DO NOT MERGE label?

@BradReesWork
Copy link
Member

@harrism I marked it as blocked based on your comment "After rapidsai/rmm#725 is merged," If there is not an issue for cuGraph, then I'll merge it now

@BradReesWork BradReesWork removed Blocked Cannot progress due to external reasons DO NOT MERGE Hold off on merging; see PR for details labels Mar 17, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a7c4ebd into rapidsai:branch-0.19 Mar 17, 2021
v0.19 Release automation moved this from PRs to Done Mar 17, 2021
@harrism
Copy link
Member Author

harrism commented Mar 18, 2021

Ah sorry, I meant RMM 725 would break cuGraph build if merged, but this was safe before and after 725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschaffer aschaffer aschaffer approved these changes

@afender afender afender approved these changes

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harrism @BradReesWork @aschaffer @afender @seunghwak