Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect.password should be Option<Vec<u8>> instead of Option<String>. #10

Closed
vincentdephily opened this issue Oct 14, 2019 · 0 comments
Closed

Connect.password should be Option<Vec<u8>> instead of Option<String>. #10

vincentdephily opened this issue Oct 14, 2019 · 0 comments

Comments

@vincentdephily
Copy link
Collaborator

Cf http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718031 : The Password field contains 0 to 65535 bytes of binary data (as opposed to most other fields like username which are UTF-8 encoded strings.

I don't actually use passwords myself, but I spotted this while checking the spec against my implementation.

Obviously this would be an API-breaking change.
@vincentdephily vincentdephily mentioned this issue Oct 14, 2019
Closed
vincentdephily added a commit to vincentdephily/mqttrs that referenced this issue Oct 16, 2019
@vincentdephily
Refactor: Connect.password and Connect.last_will.message are Vec<u8>,…
d0d05a4 
… not String.

As per MQTT spec.

Fixes 00imvj00#10

Breaking change.

Along with the type change, code was reorganized a bit, in particular 'use' statements and moving
read functions from utils to encoder, matching the write functions' location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentdephily