This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Cleanup launcher source #10
Comments
markdryan
pushed a commit
that referenced
this issue
Apr 15, 2016
This data structure is needed to allow us to refactor the instanceLoop. Without this data structure splitting the instance loop into multiple functions would require passing a huge number of parameters to those functions. Partial fix for issue: #10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
that referenced
this issue
Apr 15, 2016
Partial fix for issue: #10 The code is much less indented and easier to read now. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
ciao/ciao-launcher/main.go Line 529: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo) main() has now been split in two. This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
Fix the following gocyclo warning: ciao/ciao-launcher/instance.go Line 231: warning: cyclomatic complexity 17 of function (*instanceData).instanceLoop() is high (> 15) (gocyclo) The switch statement that processes instance commands has been moved to its own method, instanceCommand. This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
Fix the following gocyclo error: ciao/ciao-launcher/qemu.go Line 568: warning: cyclomatic complexity 22 of function qmpConnect() is high (> 15) (gocyclo) This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
ciao/ciao-launcher/main.go Line 529: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo) main() has now been split in two. This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
Fix the following gocyclo warning: ciao/ciao-launcher/instance.go Line 231: warning: cyclomatic complexity 17 of function (*instanceData).instanceLoop() is high (> 15) (gocyclo) The switch statement that processes instance commands has been moved to its own method, instanceCommand. This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
May 4, 2016
Fix the following gocyclo error: ciao/ciao-launcher/qemu.go Line 568: warning: cyclomatic complexity 22 of function qmpConnect() is high (> 15) (gocyclo) This is also a partial fix for ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
The first bullet point has been implemented. |
In the end I decided not to implement the second bullet point, i.e., split up payloads. The reason is that payloads.go contains parses and generators for the various yaml payloads that launcher processes. I was planning to move these functions into the files that use them but, it turns out that they're used by different files whose code runs in different go routines. Splitting up payloads would then require splitting up the yaml parsing and generating code. |
markdryan
pushed a commit
to markdryan/ciao
that referenced
this issue
Jun 27, 2016
The code for the instance go routine is split over a number of different files. These files have been renamed to make it obvious in which context their code runs. Code that is not unique to the instance go routine, i.e., the error types for specific commands has been moved to new files. Fixes: ciao-project#10 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
kaccardi
added a commit
to kaccardi/ciao
that referenced
this issue
Aug 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The launcher source needs to be cleaned up a little
The text was updated successfully, but these errors were encountered: