ICE workaround for nc++ #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Hi @kruus, Could you please review my small style patch and confirm you are fine with it? |
|
Good eyes — now even shorter and clearer! Remote vector machine is still
offline, so I’ll sign off as soon as I’ve run a final non-x86 check.
…On Fri, Jan 5, 2018 at 8:54 PM Evarist ***@***.***> wrote:
Hi @kruus <https://github.com/kruus>,
Could you please review my small style patch and confirm you are fine with
it?
If so, I will merge the changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#176 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFu-EtnahA1c39lekoCboYeTqGZL-M1Lks5tHtI_gaJpZM4RTjUJ>
.
|
|
sure, will wait :) |
|
Verified -- OK to merge. |
|
Merged, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
" /* Is it ugly enough? */ " ... I used to be OK with this correct code, but ...
... now it is generates an ICE in the new compiler we're running for the NEC Aurora vector processor. This PR seems to circumvent the ICE. The common-code ugliness is moved to a new private initialize function, and the constructor idioms look simpler and more similar.
The "if (active_) reorder(...)" mod seems pedantically OK, but please think about it.
I like the most recent release. 👍