Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
" /* Is it ugly enough? */ " ... I used to be OK with this correct code, but ...
... now it is generates an ICE in the new compiler we're running for the NEC Aurora vector processor. This PR seems to circumvent the ICE. The common-code ugliness is moved to a new private initialize function, and the constructor idioms look simpler and more similar.
The "if (active_) reorder(...)" mod seems pedantically OK, but please think about it.
I like the most recent release. 👍