Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC __TBB_CPP17_DEDUCTION_GUIDES_PRESENT is wrong #117

Closed
Laibalion opened this issue Jan 7, 2019 · 1 comment
Closed

MSVC __TBB_CPP17_DEDUCTION_GUIDES_PRESENT is wrong #117

Laibalion opened this issue Jan 7, 2019 · 1 comment

Comments

@Laibalion
Copy link

__TBB_CPP17_DEDUCTION_GUIDES_PRESENT is incorrectly defined for MSVC usage.

in tbb_config.h it's defined as
‘‘#define __TBB_CPP17_DEDUCTION_GUIDES_PRESENT (_MSVC_LANG >= 201703L)’
instead of
‘#define __TBB_CPP17_DEDUCTION_GUIDES_PRESENT (_MSVC_LANG >= 201703L && _MSC_VER >= 1914)’

See https://docs.microsoft.com/en-us/cpp/visual-cpp-language-conformance?view=vs-2017 for language conformance and https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B for MSVC macro version-values linked with VS 2017 updates.
@Laibalion Laibalion mentioned this issue Jan 7, 2019
Closed
@tbbdev
Copy link
Contributor

tbbdev commented Mar 21, 2019

Fixed in TBB 2019 Update 4.

@tbbdev tbbdev closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbbdev @Laibalion