New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed HashCompare constructor in concurrent_hash_map #63

Open
wants to merge 2 commits into
base: tbb_2018
from

Conversation

Projects
None yet
3 participants
@arewedancer

arewedancer commented Jun 28, 2018

Hi,
This is a followup fix on the issue reported on the TBB forum. https://software.intel.com/en-us/forums/intel-threading-building-blocks/topic/780000.

Now the example in the gist can build and work.
https://gist.github.com/arewedancer/a6ac95ddd800b4da27a943a406bf8226

Thanks!

@akukanov

This comment has been minimized.

akukanov commented Jun 29, 2018

Hi @arewedancer, unfortunately fixing the issue in this way breaks source compatibility (in case an allocator was specified for a ctor call) and therefore is undersirable. I think a bunch of new ctors needs to be added; it's also aligned with the C++ library practice for associative containers.

@arewedancer

This comment has been minimized.

arewedancer commented Jul 3, 2018

Hi, Alexey(@akukanov ), Thanks for your feedback! So rolled back original constructor interface and added additional ones. Please review.

@hjmjohnson

This comment has been minimized.

hjmjohnson commented Nov 10, 2018

@arewedancer Is this change compatible with 2019_U2 release?

@akukanov

This comment has been minimized.

akukanov commented Nov 21, 2018

@hjmjohnson, @arewedancer, the changes in 2019_U2 are essentially the integration of this merge request. This is mentioned in the CHANGES file as well, though we forgot to mention the author of the contribution - which we will fix.

@arewedancer

This comment has been minimized.

arewedancer commented Nov 26, 2018

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment