Haiku support #64
Haiku support #64
Conversation
|
Any news here? |
|
Does tests work well? |
|
Yep, and we use tbb since long for the Blender and for other ports. |
|
@extrowerk, thank you for the contribution. We will consider its integration and notify you about the decision. |
There was a problem hiding this comment.
Overall, the patch is good. However, there is a concern about a lot of unrelated stuff like Intel Compiler, Itanium (ia64) architecture and so on. Could you clean up the haiku.gcc.inc and haiku.inc to contain only currently supported stuff, please? (Unfortunately, we cannot do it ourselves because we do not have any experience with Haiku. However, we are thinking about some refactroing to move out some common parts of different platform so this clean up will help us to determine the common parts better).
|
@alexey-katranov : Thanks, you have right, i try my best to clean those files up. |
|
Any news here? |
build/haiku.gcc.inc
Outdated
| ifeq (ia64,$(arch)) | ||
| ASM_FLAGS += -xexplicit | ||
| TBB_ASM.OBJ += atomic_support.o lock_byte.o log2.o pause.o ia64_misc.o | ||
| MALLOC_ASM.OBJ += atomic_support.o lock_byte.o pause.o log2.o |
There was a problem hiding this comment.
Should it be removed as well?
| /* Futex definitions */ | ||
| #include <sys/syscall.h> | ||
| #endif | ||
|
|
||
| #if defined(SYS_futex) |
There was a problem hiding this comment.
It looks like that SYS_futex can be defined on Haiku. If not, move #endif on line 33 to the end of the file.
|
Some tests failing, do not merge yet. |
|
Haiku's tls and pthread implementation have some shortcomings/bugs, so some test fails, more info here: __tls_get_addr: https://dev.haiku-os.org/ticket/14304 |
|
Fixed on Haiku side: https://git.haiku-os.org/haiku/commit/?id=df3de4792e9b20d073d16acccc20c37f1114ea37 |
|
Hmm... rebasing went wrong somewhere? |
|
Let's close it, i think i targeted a wrong branch here. |
No description provided.