-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.99] Navbar fixes in event&contentpage #28
Conversation
trigger-top number undefined The distance px to top of target to trigger top affix. (if not set, use top prop) top number undefined The css top property after trigger top affix. (if not set, use trigger-top prop) What could have happened here is that you specified only one and the other was set to the same value, which caused the issue. I modified the top value to reflect what i did on my console but i'm not sure if this will really work as intended as i have no proof of testing
Ah yeah, now i recalled what was going on before. I was trying to make navbar's width met the width of content. However, once i scroll down and triggered the affix effect, the width of the nav bar will be shrunk. So it looks weird when it's attached to the top. I failed to fixed the width issue and choose to leave there a blank only to make it look better. |
I honestly like how the navbar is small. I now know it's unintended but if that was big as the whole width of the page it would look kinda oppressive, this way is cleaner in my eyes. |
i mean not the whole page, but the text area. |
so the actual problem is when you scroll down the page and triggered the affix, the width suddenly shrunk which is not i expected. I hope the navbar can keep it's width |
It makes sense that by adding position: fixed the width shrinks tho, cause it's no more relative to the previous parent. I'll play around a bit and see if i can find solutions to that |
"trigger-top number undefined The distance px to top of target to trigger top affix. (if not set, use top prop)"
"top number undefined The css top property after trigger top affix. (if not set, use trigger-top prop)"
(https://www.naiveui.com/en-US/dark/components/affix)
What could have happened here is that you specified only one and the other was set to the same value, which caused the issue. I modified the top value to reflect what i did on my console but i'm not sure if this will really work as intended as i have no proof of testing