Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static instances for Base16/32/64 implementations #117

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Add static instances for Base16/32/64 implementations #117

merged 2 commits into from
Jun 2, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Jun 2, 2023 •
edited
Loading

Closes #115

Static instances with widely used default settings are now available at:

  • Base16.INSTANCE
  • Base32.Crockford.INSTANCE
  • Base32.Default.INSTANCE
  • Base32.Hex.INSTANCE
  • Base64.Default.INSTANCE
  • Base64.UrlSafe.INSTANCE

@05nelsonm 05nelsonm self-assigned this Jun 2, 2023
05nelsonm
05nelsonm commented Jun 2, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@05nelsonm
Copy link
Owner Author

Should use @JvmField instead of @JvmStatic so the signatures are correct.

@05nelsonm 05nelsonm merged commit e585bb7 into master Jun 2, 2023
3 checks passed
@05nelsonm 05nelsonm deleted the issue/115-static-instance branch June 2, 2023 15:56
@05nelsonm 05nelsonm mentioned this pull request Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add static instances for higher level implementations
1 participant
@05nelsonm