Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move builders to package ...encoding.base* #126

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Jun 20, 2023

Refer to #124

Note: This PR needs to be tested yet to see if the proposed deprecation cycle will work. Will publish a -SNAPSHOT to see if new module exports would work. Otherwise, ...encoding.builders packages must be deleted entirely and a major version release needs to be published.

Adding the blocked label to prohibit merging until the aforementioned testing of the -SNAPSHOT is completed.

@05nelsonm 05nelsonm self-assigned this Jun 20, 2023
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@05nelsonm
Copy link
Owner Author

JPMS still complains. See #124 (comment)

Will have a follow up PR to prepare 2.0.0 release with API breaking changes.

@05nelsonm 05nelsonm removed the blocked label Jun 21, 2023
@05nelsonm 05nelsonm changed the title Fix JPMS split packages Move builders to package ...encoding.base* Jun 21, 2023
@05nelsonm 05nelsonm merged commit 640bd82 into master Jun 21, 2023
3 checks passed
@05nelsonm 05nelsonm deleted the issue/124-jpms-split-packages branch June 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant